Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27953 ) Change subject: bts_trx_vty: assume abort after TSC warning ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/27953/comment/cb4e8cf2_6f68a4a7 PS1, Line 9: libosmocore aborts when vty commands return CMD_WARNING

This is the case when parsing the config file, but not when a VTY command is received via telnet at […] Right. Adjusted the commit message. Do you think this patch is still useful or should I drop it?

File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27953/comment/ad62a3e9_c8aa17b3 PS1, Line 322: ts->tsc = -1;

I would remove this line too. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I041150c9ce27caca6029ed54444562bb6cdcc57a Gerrit-Change-Number: 27953 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 09:34:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment