Change in libosmo-gprs[master]: sndcp: Initial libosmo-gprs-sndcp support
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 ) Change subject: sndcp: Initial libosmo-gprs-sndcp support ...................................................................... Patch Set 13: Code-Review+1 (5 comments) File include/osmocom/gprs/sndcp/sndcp.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/15af8ef5_db3d3f09 PS12, Line 8: osmocom/core/msgb.h
You're not using msgb API in this file, why including it here? Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/7d352155_f31e14ad PS12, Line 13: GPRS_
missing OSMO_ prefix in public API Done
File include/osmocom/gprs/sndcp/sndcp_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/30671952_53f44932 PS12, Line 117: OSMO_GPRS_SNDCP_BSSGP_
OSMO_GPRS_SNDCP_SNSM_ Done
File tests/sndcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/9894956c_a073622d PS12, Line 53: $(NULL)
" No newline at end of revision file. […] Done
File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/97062b72_459d0a9e PS12, Line 56: AT_CLEANUP
" No newline at end of revision file. […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie05b5d721cf0a6147ed45c1feb75ad829865252b Gerrit-Change-Number: 30490 Gerrit-PatchSet: 13 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 12:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
fixeria