Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33308 ) Change subject: mgcp-client: Add keepalive feature ...................................................................... Patch Set 4: (2 comments) File include/osmocom/mgcp_client/mgcp_client_internal.h: https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/9ec15b9c_c5525e19 PS4, Line 22: conn_up

one mihgt have differentiated betwween UP, DOWN and UNKNOWN. […] well, we really never know if they are UP, we just guess they are UP since they answered some time ago. The only thing that really changes is how far ago we ended up knowing that it was alive. So I'm not really sure we benefit from adding the UNKNOWN state, imho it makes things more confusing, but I can add it if you think it makes more sense.

File src/libosmo-mgcp-client/mgcp_client_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/c9124941_a8682974 PS4, Line 676: pool_member->clien

one could also keep the bool conn_up and add a check here if keepalives are actually enabled. […] not sure if it really benefits from operational point of view, since the MGW in UNKNOWN state should be picked at some point (so same as UP), and then at that point it may already become UP.

-- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3dc74c78548d017f272da863d5282dc5e0020ca3 Gerrit-Change-Number: 33308 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 14:01:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment