[M] Change in libosmocore[master]: osmo_io: Avoid potential double free when sending msgb - gerrit-log

22 Aug 2023


      Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 )
Change subject: osmo_io: Avoid potential double free when sending msgb
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
...
I'm also not 100% happy with it. […]
ACK
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/ee08d580_ab1b0f9b 
PS2, Line 136: void iofd_handle_recv(struct osmo_io_fd *iofd, struct msgb *msg, int rc, struct iofd_msghdr *msghdr);
this function being added and code being moved really looks unrelated to this patch. Please split this patch into 2.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34144
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94
Gerrit-Change-Number: 34144
Gerrit-PatchSet: 2
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 22 Aug 2023 15:06:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment