Attention is currently required from: pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email )
Change subject: Add Cisco like DSCP configuration support ......................................................................
Patch Set 3:
(8 comments)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/050d452a_69d7f9... : PS1, Line 423: asp->cfg.ip_dscp = 0;
Ok fine, but since here you are resetting ip_dscp, I think it's a good idea to if (asp->cfg. […]
Done
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/7fac4c0f_00029b... : PS3, Line 440: ss7_asp_apply_ip_dscp(asp);
btw, it may make sense to rename this "ss7_asp_apply_ip_dscp" into "ss7_asp_apply_qos_class()"
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/236829c3_818e46... : PS3, Line 467:
Better keep the qos-class commands in this place rather than above, to follow the order in ss7_vty_i […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/82a15355_d77d1c... : PS3, Line 1458: if (asp->cfg.ip_dscp != 0)
you can use "else if" here, to denote explicitly that ip-dscp can only be >0 if qos_class is not set […]
Done
File src/ss7_xua_srv.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/e4ca32d2_6389fc... : PS3, Line 417: else
logic changed here, missing "if (xs->cfg.ip_dscp != 0)". […]
Done
File src/ss7_xua_srv_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/f30af080_165227... : PS3, Line 152: DEFUN_ATTR(xua_qos_class, xua_qos_class_cmd,
Move these further below to match ss7_vty_init_node_oxs() order.
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/482d898f_2f41d0... : PS3, Line 289: if (xs->cfg.ip_dscp)
else if
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b977587b_b33858... : PS3, Line 407: install_lib_element(L_CS7_XUA_NODE, &xua_qos_class_cmd);
Move this below init_ip_dscp, as in the asp vty case.
Done
-
jolly