fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email ) Change subject: fixup: diameter: fix unused macro param in ?SERVICE ...................................................................... fixup: diameter: fix unused macro param in ?SERVICE The Product-Name must be a string (list), not an atom. Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Fixes: 1545311 "diameter: fix unused macro param in ?SERVICE" --- M src/osmo_dia2gsup.erl 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index eab34a3..26376a4 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -96,7 +96,8 @@ %% @callback gen_server init(State) -> % DIAMETER side - diameter:start_service(?SVC_NAME, ?SERVICE(?MODULE)), + ProdName = atom_to_list(?MODULE), + diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Gerrit-Change-Number: 38427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de>