Attention is currently required from: lynxis lazus.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email )

Change subject: Add maintenance mapping support to osmo-remsim-server ......................................................................

Patch Set 3:

(5 comments)

Patchset:

PS2:

Would be the name SLMAP_S_SUSPEND more precise than SLMAP_S_INACTIVE? […]

When a maintenance mapping is added while there is a normal mapping, the maintenance mapping will start beein INACTTIVE. This means that the INACTIVE state may entered before any mapping is performed.

I will add tests.

Commit Message:

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/4d1089e0_9e046db0?u... : PS2, Line 19: * The normal mapping is deleted and put into INACTIVE state.

From the bankd side, the mapping is deleted, but for the server this is kept, right?

Yes. The bankd is not aware of any maintenance mapping. It just gets disconnected from one client and connected to the other.

File src/server/rspro_server.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/fa43ce3e_8febe0a4?u... : PS2, Line 385: llist_for_each_entry(map, &slotmaps->mappings, list) {

Is this still correct? Couldn't be there 2 mappings here which are both entering S_NEW state?

Good catch. This is actually not what I want. It still works, because when the two mappings become ACTIVE, the one to be suspended will be deleted. I will add a check, so that the INACTIVE mappings are not touched.

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/e2e71fcb_33122734?u... : PS2, Line 462: clinet

client

Done

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/87f9dea1_6f2771db?u... : PS2, Line 466: n

being?

Done