Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32222 ) Change subject: Introduce NM FSM for GPRS Cell object ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32222/comment/dfe65c59_a49a51e6 PS3, Line 460: osmo_fsm_inst_dispatch(bts->gprs.nse.mo.fi, NM_EV_SW_ACT, NULL); not sure, but don't you need to add here:

osmo_fsm_inst_dispatch(bts->gprs.cell.mo.fi, NM_EV_SW_ACT, NULL);

File src/common/nm_gprs_cell_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32222/comment/9bc3b6fa_dbd866f6 PS3, Line 47: nse cell? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5fd1d17da09a5f0eee3d69fcb4788c106a240e21 Gerrit-Change-Number: 32222 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 06 Apr 2023 09:45:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment