Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email ) Change subject: pcuif_proto: drop support for PCUIF v10 ...................................................................... Patch Set 2: (3 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/ff9c86c5_b09d493a PS1, Line 16: #define PCU_IF_MSG_DATA_CNF 0x01 /* (deprecated) */

this does no longer exist in v11 afaiu Done

https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/b70ecf4e_4462b783 PS1, Line 38: #define PCU_IF_SAPI_AGCH 0x02 /* (deprecated) */

this does no longer exist in v11 afaiu Done

File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/9a046484_88c4af05 PS1, Line 1050: if (plen >= 0) {

{} can be removed. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8 Gerrit-Change-Number: 34706 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 16 Oct 2023 09:55:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment