[S] Change in osmo-bsc[master]: abis_rsl: Add rach expiry timeout
Attention is currently required from: fixeria. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email ) Change subject: abis_rsl: Add rach expiry timeout ...................................................................... Patch Set 4: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/35475/comment/2752ab53_466fba6e PS3, Line 7: abis_rsl: Separate rach expiry delay from radio link timeout
Please elaborate more why a separate parameter is needed (here in COMMIT_MSG). Ack
File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35475/comment/6ad723c8_438622ae PS3, Line 777: expiry timeout
Let's combine it into a single command item `expiry-timeout`. Ack
https://gerrit.osmocom.org/c/osmo-bsc/+/35475/comment/c8eba3d6_3ce9690e PS3, Line 4532: vty_out(vty, " rach max-delay %u%s", bts->rach_max_delay, VTY_NEWLINE);
You're missing to print `rach expiry-timeout` here. Ack
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iff7266672dd8bc9ce2b34b0478d98fb70691f425 Gerrit-Change-Number: 35475 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jan 2024 07:20:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
matanp