Attention is currently required from: fixeria, pespin.
Hoernchen has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 )
Change subject: ran emulation: allow multiple reset attempts
......................................................................
Patch Set 2:
(2 comments)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/07f3f08b_9ce9…
PS1, Line 526: while (attempts > 0) {
IMO, the loop approach is easier to read. […]
I
didn't want to use for due to the long variable name, which made for look ugly.
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/d69eed53_abb0…
PS1, Line 143: bssap_reset_retries
All module parameters star with 'mp_', please
align the naming.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928
Gerrit-Change-Number: 27602
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Mar 2022 14:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment