Attention is currently required from: fixeria, jolly, laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... Patch Set 3: (9 comments) File tests/soft_uart/soft_uart_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/bd56ca6f_34088603 PS3, Line 112: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/cc499aa2_ebf3217b PS3, Line 125: "0 11110010 1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/ca8e9879_a8e41844 PS3, Line 132: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/a7570a83_bc54520c PS3, Line 145: "0 11110010 1F1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/37770bf2_ccfa7c01 PS3, Line 153: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/e3320e33_221ef445 PS3, Line 164: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/3cfae0fd_f805d91f PS3, Line 176: "F" /* flush! */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/ad0b5bb4_d602e3f5 PS3, Line 186: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12470): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/f8015102_53b29b09 PS3, Line 198: "F" /* flush! */ ); space prohibited before that close parenthesis ')' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 10:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment