Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34060 ) Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH ...................................................................... Patch Set 6: (4 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34060/comment/b60a5f50_32e3754c PS5, Line 445: confirmation

Same as in the related osmo-bts patch: "Sending confirmation" may be confusing, let's make this clea […] Done

https://gerrit.osmocom.org/c/osmo-bsc/+/34060/comment/87ea5cc7_d16ba010 PS5, Line 533: struct gsm_pcu_if_agch *agch;

const Done

https://gerrit.osmocom.org/c/osmo-bsc/+/34060/comment/9c80cd95_6371c55a PS5, Line 551: rc = -EIO;

So if `agch->confirm == true`, but `rsl_imm_assign_cmd()` fails, we still send the confirmation. […] That is indeed wrong. Thanks.

https://gerrit.osmocom.org/c/osmo-bsc/+/34060/comment/7e6b1cb0_4c4c6407 PS5, Line 555: gsm48_imm_ass = (struct gsm48_imm_ass *)agch->data;

You're setting this pointer, but not using it within this `case`. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I709c27adaf09a6766cfde4d76d878626d30ebb3c Gerrit-Change-Number: 34060 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 09:03:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment