Attention is currently required from: pespin, fixeria.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32735 )

Change subject: gmm: Allow passing old RAI during attach ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/gprs/gmm/gmm_prim.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32735/comment/a9393714_f6be9c37 PS1, Line 112: struct gprs_ra_id old_rai; I wonder where those old_rai fields are populated.

File src/gmm/gmm_pdu.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32735/comment/a90879e9_4eb235b0 PS1, Line 224: gsm48_encode_ra(raid_enc, &gmme->ra); I guess here we use the current ra as old ra since we are getting an attach request so the ra we currently stored will become the new old ra. This means that this is correct.

File src/gmm/gmm_prim.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32735/comment/e542e3bb_f7b13cc4 PS1, Line 389: here we use the old_rai, but where is that field populated before?