Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 and release 8 additions to PacketCellChangeNotification ...................................................................... Patch Set 7: (3 comments) File library/RLCMAC_CSN1_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/5e728d50_87884... PS7, Line 999: record of EutranCCNMeasReportItem I recommend specifying the min/max length here: `type record length(1..4) of EutranCCNMeasReportItem` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/a7266029_b003c... PS7, Line 1001: uint7_t It's defined as `bit (3)`, so `uint3_t`. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/b699ae1c_b79ce... PS7, Line 1069: variant (eutran_target_cell) "PRESENCE(eutran_target_cell_presence = '1'B)" missing `PRESENCE` attribute for `eutran_ccn_meas_rep`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Jun 2023 11:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment