Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283 ) Change subject: hnbgw: Avoid allocating SCCP conn id >0x00fffffe ...................................................................... Patch Set 1: Code-Review+2 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283/comment/8dd15536_b64c2e0d PS1, Line 9: This breaks use of M3UA/SCCP after 2**24 connection IDs have been (sounds a bit like *this patch* breaks M3UA) File src/osmo-hnbgw/context_map.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283/comment/7b4d6474_95b9eebd PS1, Line 62: * The source reference number is a 4 octet long integer. (tab spacing in the comment is a bit unusual?) https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283/comment/d217a8f9_0fd256d8 PS1, Line 63: * This isallocated by the source SUA instance. (space after "is") -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I03bad960f65fbff6e467def5bba60fefb328f962 Gerrit-Change-Number: 30283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Nov 2022 23:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment