Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33651 ) Change subject: osmo-bts-trx: implement TCH/F2.4 support for CSD ...................................................................... Patch Set 1: (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33651/comment/3312aa26_f3d76d8e PS1, Line 846: return can we really do this? do we really implement all speciifed CSD channel rates now? don't they also specify rates for HSCSD with multiple timeslots, which we certainly don't implement? I see stuff like RSL_CMOD_CSD_T_32k0 ... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I31c59a78a362986b0cd1bc6650c325ee9f206519 Gerrit-Change-Number: 33651 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:30:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment