Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38001?usp=email ) Change subject: pySim-shell: print cardinfo hexstrings in lowercase ...................................................................... Patch Set 3: (1 comment) Patchset: PS2:

this smells a bit like: […] I also don't like having to use `.lower()` everywhere and would proceed as suggested above. That class should likely go to the newly born https://gitea.osmocom.org/osmocom/pyosmocom?

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/38001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60 Gerrit-Change-Number: 38001 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Sep 2024 08:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>