Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email ) Change subject: socket: Introduce APIs osmo_sock_multiaddr_{add,del}_local_addr() ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/34607/comment/73904621_0b0226be PS1, Line 1279: char strbuf[512];

can be moved to the scope of `if` below, but not critical Done

https://gerrit.osmocom.org/c/libosmocore/+/34607/comment/bd1c7f96_643021c3 PS1, Line 1355: strbuf

same here Done

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7d643c2a0c53f479bfd0d5c36d08c0c01953 Gerrit-Change-Number: 34607 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Oct 2023 16:48:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment