Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31118
)
Change subject: Try to work around coverity false positives in macros
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31118/comment/49571c2d_31986933
PS1, Line 498: // coverity[unsigned_compare:FALSE]
Did you thik about simply casting to int inside the macro?
#define ALG_A5_NR_TO_RSL(A5_N) ((int)(A5_N) >= 0 ? ((A5_N)+1 : 0)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31118
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479
Gerrit-Change-Number: 31118
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 31 Jan 2023 13:32:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment