Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33124 ) Change subject: Switch from pycryptodome to pycryptodomex ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: This looks good to me but there is one thing I don't understand (see comment) File README.md: https://gerrit.osmocom.org/c/pysim/+/33124/comment/a1421881_41b2e8fb PS1, Line 57: python3-pycryptodome \ I don't understand this, isn't the pycryptodome dependency already satisfied when pycryptodomex is installed via pip? Why do we need to install it via a debian package and pip? (You also mention in the commit message that you want to switch to pycryptodomex on all platforms) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04daed01f51f9702595ef9f9e0d7fcdf1e4adb62 Gerrit-Change-Number: 33124 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Thu, 01 Jun 2023 08:48:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment