Change in pysim[master]: ts_51_011: Implement Extended BCD Coding
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31066 ) Change subject: ts_51_011: Implement Extended BCD Coding ...................................................................... Patch Set 2: (2 comments) File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/31066/comment/de70b284_cf61cc9e PS2, Line 347: # we only translate a=* / b=# as they habe a clear representation typo: have https://gerrit.osmocom.org/c/pysim/+/31066/comment/5750772b_0aebd402 PS2, Line 366: 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))), Just to be sure: Shouldn't this be: ExtendedBcdAdapter(Rpad(Bytes(10))) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifcec13e9b296dba7bec34b7872192b7ce185c23c Gerrit-Change-Number: 31066 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 25 Jan 2023 13:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
pespin