Attention is currently required from: pespin, dexter.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 )

Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ......................................................................

Patch Set 3:

(5 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/b5cc6710_3f11d6ed PS2, Line 8:

I will cover this topic in proper detail in June OsmoDevCall, but here is a shorter version: the pro […]

The new patchset has a reworded commit message - please review.

File include/osmo-bts/lchan.h:

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/dc80b0a5_b2a1be97 PS2, Line 281: } nonamr;

I'll go with dexter's suggestion of dtx_fr_efr for the new substruct, plus renaming the old dtx subs […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/fd4eefc1_b94817c8 PS2, Line 282: uint8_t last_cmr;

dexter's comment is correct - the last_cmr member is in the larger tch substruct, not in either of t […]

Done

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/178637d9_25ae4dc5 PS2, Line 1315: if (lchan->type == GSM_LCHAN_TCH_F)

I'll change this code to use nested switch statements for lchan->type and lchan->nr in the next vers […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/7a1659ad_24dea7cc PS2, Line 1334: bool is_nonamr_sid = false;

Will do.

Done