Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35005?usp=email ) Change subject: core: add parity calculation functions for uint{32,16,8}_t ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/35005/comment/032d4cf1_2459d24a PS1, Line 8: could you indicate the intended first use, to answer why we're adding this? File include/osmocom/core/bits.h: https://gerrit.osmocom.org/c/libosmocore/+/35005/comment/e4077f5a_fd7b0695 PS1, Line 129: x ^= (could call osmo_parity_u16() here, etc) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d6265eac5ce062276a40f4968b129d8702c6117 Gerrit-Change-Number: 35005 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 13 Nov 2023 02:59:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment