Attention is currently required from: osmith, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/28809 )
Change subject: trxcon: rework trxcon_fsm, move into a separate file
......................................................................
Patch Set 3:
(5 comments)
File src/host/trxcon/src/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/d75ae639_2df99d3a
PS3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually
applied.
can this be fixed? the comment sounds like it
can't but there's a FIXME infront
No, it cannot be fixed. This is a
limitation of the osmo_fsm API: you cannot indicate a negative outcome from the .action
callback. I we were in C++ land, I would simply raise an exception, but this is C. Adding
this FIXME to not forget about this problem. Maybe I'll find a solution later.
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/d0bc3771_81e23712
PS3, Line 52: /* TODO: osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); */
kept on purpose?
Yes. This is going to be fixed
in a follow up patch, not here.
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/9442e46b_2fe16d08
PS3, Line 127: /* TODO: timeout */
kept on purpose?
Yes, this is a potential
improvement, so that's why TODO.
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/b0d88f35_c989d4b6
PS3, Line 210: ");
missing \n
Nice catch! Thanks!
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/2ebc644c_b5dfa87b
PS3, Line 280: /* TODO: set proper .snr */
kept on purpose? same below
This TODO existed
before this commit, so I'll keep it.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28809
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifaf63ead9dd180181358e771367b2a686ba159ca
Gerrit-Change-Number: 28809
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment