Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/078ac4ba_1cf61... PS2, Line 986: /* What to Codec (Chosen) to send back in Assignment Complete */ "What to Codec to" doesn't make sense to me? You mean "What codec to encode/transmit back in Assignment Complete"? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/bc9a68e1_bf657... PS2, Line 993: BSSMAP_FIELD_CodecElements re_ass_req_codecs, Sounds like "optional" is missing in this field. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/0ed52d20_3a444... PS2, Line 995: re_ass_compl_chosen_codec

Done Sounds like "optional" is missing in this field.

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53 Gerrit-Change-Number: 35053 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 27 Nov 2023 16:18:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment