[S] Change in osmo-msc[master]: libvlr: allow to use the same key slot for multiple ciphering commands
Attention is currently required from: laforge, neels, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email )
Change subject: libvlr: allow to use the same key slot for multiple ciphering commands ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
I re-considered this commit. I'll try to improve the ciphering usage. […]
Done
File src/libvlr/vlr_auth_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/53ac1efe_e21747d4?usp=... : PS1, Line 126: struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, 0);
id we always pass zero here, why having the param at all?
Done
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/1a951f0e_c790c18b?usp=... : PS1, Line 135: int max_reuse_count)
this should be removed then too?
Done
-
lynxis lazus