Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30304 ) Change subject: rate_ctr: update estimation code ...................................................................... Patch Set 4: (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30304/comment/25438ca8_893e7aca PS4, Line 348: static int rate_ctr_timer_cb_sec(struct osmo_fd *ofd, unsigned int what) AFAIU you can move all the code block of these 4 functions simply passing RATE_CTR_INTV_* as a parameter. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I07232e9ff8bd62403ae82d9bd60d967d40b54ebc Gerrit-Change-Number: 30304 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Nov 2022 10:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment