Attention is currently required from: fixeria, laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email )
Change subject: osmo-upf: add VTY 'gtp-echo' command ......................................................................
Patch Set 3:
(2 comments)
File src/osmo-upf/upf_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/286d37cb_d04776b5?usp=... : PS1, Line 491: tx to
Would you accept this? […]
I would write "[(a|b) ARG]" but it's a limitation of VTY that we need to write "[(a|b)] [ARG]"... four lines of argc logic is much less code than two DEFUNs plus a static function... but i see your point.
Wow, I wasn't aware of VTY_IPV46_CMD, so far I thought the alternatives are A.B.C.D for v4 only, or a free form ARG_NAME. (BTW, the user cannot pass "example.com" because the implementation will throw an error.)
https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/a6c19757_2ae79e8d?usp=... : PS1, Line 556: %%Error
yes, between the `%%` and `Error`
oh!
-
neels