pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38468?usp=email ) Change subject: library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum ...................................................................... library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum It is unused, plus IPCP_Types.ttcn already defines a more complete enum in IpcpConfigOptCode. Change-Id: I867ab36063db262b46fc4546c17a902699a6e37c --- M library/IPCP_Types.ttcn M library/PCO_Types.ttcn 2 files changed, 1 insertion(+), 8 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/IPCP_Types.ttcn b/library/IPCP_Types.ttcn index 657289a..18b6947 100644 --- a/library/IPCP_Types.ttcn +++ b/library/IPCP_Types.ttcn @@ -35,7 +35,7 @@ IpcpOptionList options } with { variant (len) "LENGTHTO(code,identifier,len,options)" }; -/* RFC1332 */ +/* RFC 1332 IP Control Protocol options, extensions in RFC 1877 */ type enumerated IpcpConfigOptCode { IPCP_OPT_IpAddresses ('01'O), IPCP_OPT_IpCompressionProtocol ('02'O), diff --git a/library/PCO_Types.ttcn b/library/PCO_Types.ttcn index a308c08..04b5080 100644 --- a/library/PCO_Types.ttcn +++ b/library/PCO_Types.ttcn @@ -52,13 +52,6 @@ return int2oct(enum2int(p), 2); } -/* RFC 1332 IP Control Protocol options, extensions in RFC 1877 */ -type enumerated IPCP_OPT { - IPCP_OPT_IPADDR (3), /* RFC 1332 3.3 */ - IPCP_OPT_PRIMARY_DNS (129), /* RFC 1877 1.1 */ - IPCP_OPT_SECONDARY_DNS (131) /* RFC 1877 1.2 */ -} with { variant "FIELDLENGTH(8)" }; - type set of ProtocolElement ProtocolIDList; type record ProtocolElement { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I867ab36063db262b46fc4546c17a902699a6e37c Gerrit-Change-Number: 38468 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>