[L] Change in osmo-upf[master]: pfcp-tool: n-sessions [4/4]: implement 'n <0-2147483647> session create' - gerrit-log

19 Aug 2024


      Attention is currently required from: neels.
pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email )
Change subject: pfcp-tool: n-sessions [4/4]: implement 'n <0-2147483647> session create'
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-pfcp-tool/pfcp_tool_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/37760/comment/f37d52b3_fc35b150?usp=... :
PS4, Line 1069: 		if (!(i & 0x3f) && responses_pending) {
N is 0x3f then? sounds a bit cryptic tbh.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I74a21cc31296ab89a2acda1da8ae9693c1992e66
Gerrit-Change-Number: 37760
Gerrit-PatchSet: 4
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Mon, 19 Aug 2024 09:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No