Attention is currently required from: jolly, laforge, neels, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email ) Change subject: soft_uart: implement modem status lines and flow control ...................................................................... Patch Set 3: (5 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/7f695941_4b5a2352 PS3, Line 100: gets

"gets passed" or "gets as an argument" -- I will clarify this. Done

File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/2079f190_aa7eae88 PS2, Line 398: if (active) /* assert the given line */

re: if assert and de-assert is terminology from the matching spec, then of course keep using those t […] @andreas@eversberg.eu just to confirm, am I using the terminology correctly in this patch? As we agreed in Jabber, in the example case of the RI (Ring Indicator), the modem asserts this line when it's ringing and de-asserts it when it's no more ringing.

File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/4e00c693_ca74a4f5 PS3, Line 214: OSMO_SUART_STATUS_F_RTS_RTR

RX must continue. […] Done

https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/dd6fda1d_5deb226e PS3, Line 324: OSMO_SUART_STATUS_F_CTS

The current character needs to be finished before the transmitter can stop transmitting. Ack. Implemented in the new patchset, verified by unit tests.

https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/97d7cd7f_b60397f3 PS3, Line 399: else

If you de-assert DTR, you should reset the transmitter state. […] What you suggest looks as follows to me:

* "If you de-assert DTR, you should reset the transmitter state" - if we can no longer receive, we de-assert the DTR (Data Terminal Ready) and for some reason reset the transmitter state (`suart->tx.flow_state`)? * "If you de-assert DSR, you should reset the receiver state" - if we can no longer transmit, we de-assert the DSR (Data Set Ready) and for some reason reset the receiver state (`suart->rx.flow_state`)? Could you elaborate on this please? I am trying to understand the idea here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I26b93ce76f2f6b6fbf017f2684312007db3c6d48 Gerrit-Change-Number: 35172 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: jolly <andreas@eversberg.eu> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Sun, 03 Dec 2023 21:39:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment