Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255 ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 1: (1 comment) File dia2gsup/DIA2GSUP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/32d461d9_ffa6d... PS1, Line 345: TC_authinfo_gsup_err_imsi_unknown Having separate testcases (and even separate implementations) for testing the same scenario looks redundant to me. Why not testing them all in one testcase? The cause values can be passed via `D2G_ConnHdlrPars`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 23:07:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment