Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28968 ) Change subject: Makefile.am: add 'git-version-gen' to EXTRA_DIST ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:

Why is that needed? isn't . […] To be honest, I don't know. I saw other osmo-* projects listing it in EXTRA_DIST and updated osmo-pcu for consistency. Now I checked again, and found out that it's not the case for osmo-trx (not generating .version at all), osmo-iuh, osmo-hlr, libsmpp34, libosmo-netif, nor libosmo-abis either.

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idbf4bf70d83fbf697d4a094dbb47592deaea6114 Gerrit-Change-Number: 28968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 12:20:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment