Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )

Change subject: ara_m: use class byte of current lchan ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: I agree this needs a fix - but I think the proper solution for this is to handle this generically within the scc layer. It should offer two flavours of the send_apdu_checksw() method: one that patches CLA with the lchan number, and one that doesn't. This could be two methods, or an optional argument to the existing method. The default should be to do the lchan-patching; only special commands should be excempt from it (like the OPEN CHANNEL). This way we can avoid exposing all those low-level details to other modules in the code base.