Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31112
)
Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc/bts_trx.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/ccc79925_5c8d9e5d
PS3, Line 330: /* NOTE: A static PDCH is usually handled by the BTS/PCU internally, the
BSC
I'd really move this comment inside the
is_ericsson_bts() block since it's quite ericsson specific, […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31112
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27
Gerrit-Change-Number: 31112
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 14:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment