Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/1b97e43d_0d378319?usp=... : PS6, Line 294: /* Open a channel's ctrl+data sockets. \returns 0 on success; -EIO on error */ Not sure if these in the same line are on purpose.
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/71af8c3d_7ffa9e4d?usp=... : PS6, Line 323: msgb_free(chan->tx_msg); (make sure chan->tx_msg is not allocated under any of the iofds above to avoid double free).
-
pespin