Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/1b97e43d_0d378319?usp=... : PS6, Line 294: /* Open a channel's ctrl+data sockets. \returns 0 on success; -EIO on error */ Not sure if these in the same line are on purpose. https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/71af8c3d_7ffa9e4d?usp=... : PS6, Line 323: msgb_free(chan->tx_msg); (make sure chan->tx_msg is not allocated under any of the iofds above to avoid double free). -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Sep 2026 08:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes