Attention is currently required from: daniel, fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 9: (2 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/ac29290a_d7330054?usp=ema... : PS8, Line 37: PQSQL

PGSQL or PSQL are usual acronyms for postgres. […] Done

https://gerrit.osmocom.org/c/pysim/+/41508/comment/72a70abc_64ec120c?usp=ema... : PS8, Line 261: str(Path.home()) + "/.osmocom/pysim/card_data_pqsql.cfg"

Not critical, but I guess the clean/pythonic way would be to use `os.path. […] Thanks, having the user name in the helptext is indeed something we should avoid. I remember having problems with resolving ~, but os.path.expanduser() works well when I apply it on the path when accessing opts.pqsql.

I have also fixed this for pySim-shell.py -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Mon, 22 Dec 2025 13:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>