Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email )

Change subject: libosmo-trx/client: add TRXC client (command queue) API ......................................................................

Patch Set 3:

(1 comment)

File libosmo-trx/src/trxc_client.c:

https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/005a5f69_0cfa9b1d?usp=... : PS3, Line 474: sf->cb(client, 0, sf->cb_data);

By freeing "sf" after the cb, you may end up in a double free if the user callback frees the "client […]

Many things can go wrong if the callback free()s the client - this is currently not supported and calling `osmo_trxc_client_free()` would result in an assertion failure `OSMO_ASSERT(!client->in_rx)`.