Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31615 ) Change subject: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch' ...................................................................... Patch Set 4: (1 comment) Patchset: PS4:

OSMO/DYN? as in TCH/F hmm I still prefer as little separators as possible here. For example, here:

https://gitea.osmocom.org/cellular-infrastructure/osmo-bsc/src/commit/b3de2e... (this is test output from upcoming patch 'tweak gsm_pchan_ids[]: s/OSMO_DYN/OSMODYN' https://gerrit.osmocom.org/c/osmo-bsc/+/31632' ) pchan=SDCCH8+CBCH: ts->fi->id = 0-1-0-SDCCH8_CBCH lchan->fi->id = 0-1-0-SDCCH8_CBCH-0 assignment.fi->id = msc4294967295-conn123_subscr-TMSI-0x00000423_0-1-0-SDCCH8_CBCH-0 pchan=OSMODYN: ts->fi->id = 0-1-0-OSMODYN lchan->fi->id = 0-1-0-OSMODYN-0 assignment.fi->id = msc4294967295-conn123_subscr-TMSI-0x00000423_0-1-0-OSMODYNasNONE-0 In strings like these FSM instance IDs, 'OSMODYNasNONE' or usually more like 'OSMODYNasSDCCH8', the less separators the better IMHO. just "dynamic" without "osmo"? "osmodyna" / "osmodynamic"? "FHSP"? "*" / "any"? My favorite of all suggestions is still "osmodyn" -- it is short, clear enough and easy to remember. I'm happy to change it against my opinion if there is a clear consensus among reviewers... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37719edd867c777d1ce944b8e2f1efffac38f00e Gerrit-Change-Number: 31615 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 16:41:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment