Attention is currently required from: jolly, neels. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email ) Change subject: Release BSSMAP connection when SS message is rejected ...................................................................... Patch Set 2: (1 comment) File src/libmsc/gsm_09_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/38305/comment/9399f52e_d5469d97?usp=... : PS2, Line 145: msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); I think this definetly requires a comment explaining why is the reference dropped here and probably where was this reference taken. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic6765e5d480735e67d97f0f560da24653b26d487 Gerrit-Change-Number: 38305 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:36:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No