[S] Change in pysim[master]: pySim-shell: change Prompt character to "#" after "verify_adm"
Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38884?usp=email ) Change subject: pySim-shell: change Prompt character to "#" after "verify_adm" ...................................................................... Patch Set 2: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/38884/comment/431c6180_8f8e0803?usp=ema... : PS1, Line 301:
are we sure all instances of 'reset' or 'detecting a new card' (equip, ... […] Your gut feeling is correct. There is/was indeed a problem with equip. I have fixed this now. Also I noticed that equip by itself does not reset the card, even though it resets all kinds of states in pySim-shell and even selects the MF. I have corrected this in a separate patch.
So, we do reset the adm_verifed state on reset, we reset it in the equip method, which is called from do_equip and also from the code that does the bulk script execution. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I957b9df7b5069b6fce5bf958c94e8ffda833c77f Gerrit-Change-Number: 38884 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2024 12:05:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
dexter