[S] Change in pysim[master]: Modem related fixes.
Attention is currently required from: JPM, dexter. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/pysim/+/38993?usp=email ) Change subject: Modem related fixes. ...................................................................... Patch Set 1: (1 comment) File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/38993/comment/bad1c9c5_66a5ba09?usp=ema... : PS1, Line 142: f' Oh, BTW. I am all for using f-strings, but pySim generally aims to support old Python versions. We should probably bump the minimum Python version requirement, but for now I would avoid using f-strings. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e45603a13496fff41b9f859de486143252fb28d Gerrit-Change-Number: 38993 Gerrit-PatchSet: 1 Gerrit-Owner: JPM <jean-pierre.marcotte.1@ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1@ens.etsmtl.ca> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Dec 2024 12:26:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
fixeria