Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783?usp=email ) Change subject: diameter_swx: Fix MAA and SAA parsing mixed ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/epdg_diameter_swx.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783/comment/0f26e396_64c28... PS1, Line 205: It's a usual practice to have no NL between different variants of the same function, so no need to add it here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I570dd7c0ae521ccaea5fceb7eef90b4975cb0fbc Gerrit-Change-Number: 34783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 18 Oct 2023 06:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment