Attention is currently required from: neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33686 ) Change subject: osmo_io: Add function to change the maximum length of the tx_queue ...................................................................... Patch Set 3: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/33686/comment/cf0db5b6_d79c841f PS2, Line 545: g

(end in a dot for doxygen AUTO_BRIEF) Thanks, I'll change all the other doc comments in a separate commit

https://gerrit.osmocom.org/c/libosmocore/+/33686/comment/29dba36d_17a7e140 PS2, Line 549: void osmo_iofd_set_txqueue_max_length(struct osmo_io_fd *iofd, unsigned int size)

(i find mildly curious mixing of "max_length" and "size" and "maximum size" terms, would rather stic […] Ack

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If3d1de8bffe1123002515878655ea9e02b482888 Gerrit-Change-Number: 33686 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 09:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: comment