[S] Change in osmo-sgsn[master]: gprs_sndcp_xid: double check buffer size after writing SAPIs
Attention is currently required from: dexter, lynxis lazus. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43968?usp=email ) Change subject: gprs_sndcp_xid: double check buffer size after writing SAPIs ...................................................................... Patch Set 1: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/43968/comment/33f1a1c0_aa1987ad?usp... : PS1, Line 11: that, each encoder funtion writes the remaining information to (function) File src/sgsn/gprs_sndcp_xid.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43968/comment/80c020d2_f2f34130?usp... : PS1, Line 119: if (dst_maxlen - dst_counter < 1) More simple and secure regarding unsigned negative subtraction, etc: "if (dst_maxlen <= dst_counter)" https://gerrit.osmocom.org/c/osmo-sgsn/+/43968/comment/f9dd35dd_ceb0808e?usp... : PS1, Line 162: if (dst_maxlen - dst_counter < 7) "if (dst_maxlen < dst_counter + 7)" https://gerrit.osmocom.org/c/osmo-sgsn/+/43968/comment/c0bf0165_81fd4d73?usp... : PS1, Line 245: if (dst_maxlen - dst_counter < 36) "if (dst_maxlen < dst_counter + 36)" https://gerrit.osmocom.org/c/osmo-sgsn/+/43968/comment/b743cea2_25668656?usp... : PS1, Line 306: if (dst_maxlen - dst_counter < 4) "if (dst_maxlen < dst_counter + 4)" https://gerrit.osmocom.org/c/osmo-sgsn/+/43968/comment/ecb043e2_f630a978?usp... : PS1, Line 363: if (dst_maxlen - dst_counter < 10) "if (dst_maxlen < dst_counter + 10)" -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I059c903885e21215ad1e6b835f34db2c5f70d87a Gerrit-Change-Number: 43968 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 29 Oct 2026 11:17:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
pespin