Attention is currently required from: laforge, pespin.

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email )

Change subject: CTRL: get rate_ctr_group by the id from rate_ctr_group_set_name() ......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS2:

(another resolved comment with a valid point, unresolving)

we actually still do a lot of linear iteration all over our CNI programs for finding conn state. (and did I mention the value_string iterations =)

either way:

So far we have in rate_ctr.c:

static LLIST_HEAD(rate_ctr_groups);

we can easily add a hashtable next to it and populate the hashtable as rate_ctr_group_set_name() is called. We only have to extend the public struct rate_ctr_group to add a hash entry. The struct rate_ctr_group should always be allocated via rate_ctr_group_alloc(), so it is ABI compatible when we add the hashtable entry in the end.

yes?