Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33726 ) Change subject: osmo-bts-trx: document/clarify the meaning of BUFMAX=24 ...................................................................... Patch Set 1: (1 comment) File include/osmo-bts/scheduler.h: https://gerrit.osmocom.org/c/osmo-bts/+/33726/comment/3281761c_3ddf781f PS1, Line 135: struct l1sched_meas_set buf[24]; /* up to 24 (BUFMAX) entries */

why not use BUFMAX instead of 24 then? Because `BUFMAX` is defined in a local header of osmo-bts-trx, while this header is in the common directory. Don't ask me why, I don't know, but I guess it's because osmo-bts-virtual is reusing some parts of the scheduler. I could have defined `BUFMAX` here, but IMO `sched_utils.h` is a better place.

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I95d4e4ee3938cfabc1695959cc82a1efbbf0d7ed Gerrit-Change-Number: 33726 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 21:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment