Attention is currently required from: fixeria, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )
Change subject: After writing VTY config, run sync() in a different thread ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I am quite sure the reason is "because it was easy to do". […]
If we only care about the new file (not to the backup), it is straight forward to implement with fsync(). I will resolve that.
File src/vty/command.c:
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/d73ad486_2583564b?u... : PS2, Line 3439: LOGP(DLGLOBAL, LOGL_ERROR, "Failed to create thread, syncing without thread.\n");
missing `osmo_fd_unregister()` here?
This is done at sync_complete().