Attention is currently required from: wbokslag. pespin has posted comments on this change by wbokslag. ( https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email ) Change subject: Fix preventing crashes when -d missing ...................................................................... Patch Set 1: (1 comment) File src/lower_mac/tetra_lower_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/41679/comment/a8b6272c_225f8e7b?us... : PS1, Line 198: if (tms->cur_burst.is_traffic && (type == TPSAP_T_SCH_F || (blk_num == BLK_2 && !tms->cur_burst.blk2_stolen)) && tms->dumpdir) {

line too large, I'd say put every condition between && in a new line. It may also make sense to check tms->dumpdir first.

-- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/41679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I6a857f62aae542b054cbb474594359da626762bb Gerrit-Change-Number: 41679 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Comment-Date: Tue, 16 Dec 2025 14:57:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>